Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1729073002: Update SVG tests ahead of offset* removal (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SVG tests ahead of offset* removal This converts some SVG tests to use getBoundingClientRect() instead of the deprecated offset* attributes, so that the removal CL is minimized and thus easier to revert in case of trouble. smil-scheduled-in-inactive-document-crash.html didn't actually run the problematic code because of a early finishJSTest(), which was moved. BUG=463116 R=fs@opera.com Committed: https://crrev.com/6887a15a769e9de73628346f67a4bfff71b553be Cr-Commit-Position: refs/heads/master@{#377261}

Patch Set 1 #

Patch Set 2 : update flexitem.html and grid-item-display.html too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -35 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/flexitem.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flexitem-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-display.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-display-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/resources/event-dispatching.js View 4 chunks +18 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/resources/focus-anchor-by-mouse.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/resources/check-layout.js View 1 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/check-layout-th.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/smil-scheduled-in-inactive-document-crash.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/as-iframe/svg-in-iframe.html View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/animate-svgsvgelement.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/size-follows-container-size.html View 1 chunk +6 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
philipj_slow
4 years, 10 months ago (2016-02-24 03:19:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729073002/1
4 years, 10 months ago (2016-02-24 03:20:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 04:28:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729073002/20001
4 years, 10 months ago (2016-02-24 04:54:51 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/185946)
4 years, 10 months ago (2016-02-24 08:00:18 UTC) #9
fs
lgtm
4 years, 10 months ago (2016-02-24 09:00:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729073002/20001
4 years, 10 months ago (2016-02-24 09:39:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 10:40:37 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 10:42:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6887a15a769e9de73628346f67a4bfff71b553be
Cr-Commit-Position: refs/heads/master@{#377261}

Powered by Google App Engine
This is Rietveld 408576698