Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1726743002: Remove SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, timvolodine
CC:
darktears, android-webview-reviews_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, cbiesinger, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, jfernandez, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, Manuel Rego, rjwright, rwlbuis, Stephen Chennney, shans, svillar
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/jjwLLSG_hGY/Ovi-nvEeDwAJ BUG=463116 Committed: https://crrev.com/b515424de0aa3d62c4d64f4a73cf0bff137539c8 Cr-Commit-Position: refs/heads/master@{#377283}

Patch Set 1 #

Patch Set 2 : update more tests #

Patch Set 3 : rebase on https://codereview.chromium.org/1729073002/ #

Patch Set 4 : rebase #

Messages

Total messages: 20 (9 generated)
philipj_slow
PTAL. I haven't let the dry run finish, but am pretty sure that if any ...
4 years, 10 months ago (2016-02-23 17:30:06 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726743002/1
4 years, 10 months ago (2016-02-23 17:34:28 UTC) #4
chrishtr
Please be prepared to roll this back and re-land in one more release if a ...
4 years, 10 months ago (2016-02-23 17:41:51 UTC) #5
chrishtr
lgtm
4 years, 10 months ago (2016-02-23 17:42:03 UTC) #6
philipj_slow
On 2016/02/23 17:41:51, chrishtr wrote: > Please be prepared to roll this back and re-land ...
4 years, 10 months ago (2016-02-23 17:44:05 UTC) #7
timvolodine
android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt -- lgtm
4 years, 10 months ago (2016-02-23 18:14:28 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/184342)
4 years, 10 months ago (2016-02-23 19:15:56 UTC) #10
philipj_slow
Some more tests needed to be updated, so in order to make this easier to ...
4 years, 10 months ago (2016-02-24 04:56:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726743002/60001
4 years, 10 months ago (2016-02-24 10:57:58 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-24 13:40:50 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 13:41:59 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b515424de0aa3d62c4d64f4a73cf0bff137539c8
Cr-Commit-Position: refs/heads/master@{#377283}

Powered by Google App Engine
This is Rietveld 408576698