Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1728873002: DevTools: simplify JSONValues API, prepare to the OwnPtr migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselines Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8DebuggerAgentImpl.h" 5 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
6 6
7 #include "platform/JSONValues.h" 7 #include "platform/JSONValues.h"
8 #include "platform/v8_inspector/AsyncCallChain.h" 8 #include "platform/v8_inspector/AsyncCallChain.h"
9 #include "platform/v8_inspector/IgnoreExceptionsScope.h" 9 #include "platform/v8_inspector/IgnoreExceptionsScope.h"
10 #include "platform/v8_inspector/InjectedScript.h" 10 #include "platform/v8_inspector/InjectedScript.h"
(...skipping 1437 matching lines...) Expand 10 before | Expand all | Expand 10 after
1448 m_scripts.set(parsedScript.scriptId, script); 1448 m_scripts.set(parsedScript.scriptId, script);
1449 1449
1450 if (scriptURL.isEmpty() || !parsedScript.success) 1450 if (scriptURL.isEmpty() || !parsedScript.success)
1451 return; 1451 return;
1452 1452
1453 RefPtr<JSONObject> breakpointsCookie = m_state->getObject(DebuggerAgentState ::javaScriptBreakpoints); 1453 RefPtr<JSONObject> breakpointsCookie = m_state->getObject(DebuggerAgentState ::javaScriptBreakpoints);
1454 if (!breakpointsCookie) 1454 if (!breakpointsCookie)
1455 return; 1455 return;
1456 1456
1457 for (auto& cookie : *breakpointsCookie) { 1457 for (auto& cookie : *breakpointsCookie) {
1458 RefPtr<JSONObject> breakpointObject = cookie.value->asObject(); 1458 RefPtr<JSONObject> breakpointObject = JSONObject::cast(cookie.value);
1459 bool isRegex; 1459 bool isRegex;
1460 breakpointObject->getBoolean(DebuggerAgentState::isRegex, &isRegex); 1460 breakpointObject->getBoolean(DebuggerAgentState::isRegex, &isRegex);
1461 String url; 1461 String url;
1462 breakpointObject->getString(DebuggerAgentState::url, &url); 1462 breakpointObject->getString(DebuggerAgentState::url, &url);
1463 if (!matches(m_debugger, scriptURL, url, isRegex)) 1463 if (!matches(m_debugger, scriptURL, url, isRegex))
1464 continue; 1464 continue;
1465 ScriptBreakpoint breakpoint; 1465 ScriptBreakpoint breakpoint;
1466 breakpointObject->getNumber(DebuggerAgentState::lineNumber, &breakpoint. lineNumber); 1466 breakpointObject->getNumber(DebuggerAgentState::lineNumber, &breakpoint. lineNumber);
1467 breakpointObject->getNumber(DebuggerAgentState::columnNumber, &breakpoin t.columnNumber); 1467 breakpointObject->getNumber(DebuggerAgentState::columnNumber, &breakpoin t.columnNumber);
1468 breakpointObject->getString(DebuggerAgentState::condition, &breakpoint.c ondition); 1468 breakpointObject->getString(DebuggerAgentState::condition, &breakpoint.c ondition);
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
1623 m_scripts.clear(); 1623 m_scripts.clear();
1624 m_blackboxedPositions.clear(); 1624 m_blackboxedPositions.clear();
1625 m_breakpointIdToDebuggerBreakpointIds.clear(); 1625 m_breakpointIdToDebuggerBreakpointIds.clear();
1626 resetAsyncCallTracker(); 1626 resetAsyncCallTracker();
1627 m_promiseTracker->clear(); 1627 m_promiseTracker->clear();
1628 if (m_frontend) 1628 if (m_frontend)
1629 m_frontend->globalObjectCleared(); 1629 m_frontend->globalObjectCleared();
1630 } 1630 }
1631 1631
1632 } // namespace blink 1632 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698