Have EventSender mouseups unwind better on cancellation during dragover.

Have EventSender mouseups unwind better on cancellation during dragover.

Follow up on changes brought by r376733 and check if handling of dragover
cancelled our ongoing drag. Leave early, if so.

R=dcheng,rbyers
BUG=589426
Committed: https://crrev.com/8d568b12722f02dbb2ec358ce4600b96a673c481
Cr-Commit-Position: refs/heads/master@{#377392}

[sof, 2016-02-24 16:42:30]

sigbjornf@opera.com changed reviewers:
+ dcheng@chromium.org, rbyers@chromium.org, tkent@chromium.org

[sof, 2016-02-24 16:42:30]

please take a look.

close off what I started..

[dcheng, 2016-02-24 18:29:22]

https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html
(right):

https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html:15:
eventSender.mouseMoveTo(10, 10);
Where does the mouse start from? It it was already at (10, 10), does that mean
no dragover event would ever fire?

[sof, 2016-02-24 18:39:01]

https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html
(right):

https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html:15:
eventSender.mouseMoveTo(10, 10);
On 2016/02/24 18:29:22, dcheng wrote:
> Where does the mouse start from? It it was already at (10, 10), does that mean
> no dragover event would ever fire?

last_mouse_pos is initialized as (0,0), no?

[dcheng, 2016-02-24 18:43:23]

On 2016/02/24 at 18:39:01, sigbjornf wrote:
>
https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html
(right):
> 
>
https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html:15:
eventSender.mouseMoveTo(10, 10);
> On 2016/02/24 18:29:22, dcheng wrote:
> > Where does the mouse start from? It it was already at (10, 10), does that
mean
> > no dragover event would ever fire?
> 
> last_mouse_pos is initialized as (0,0), no?

ok, just wanted to make sure it wouldn't end up depending on what test ran
before it. lgtm

[sof, 2016-02-24 18:56:54]

On 2016/02/24 18:43:23, dcheng wrote:
> On 2016/02/24 at 18:39:01, sigbjornf wrote:
> >
>
https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
> > File
>
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html
> (right):
> > 
> >
>
https://codereview.chromium.org/1728353002/diff/1/third_party/WebKit/LayoutTe...
> >
>
third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html:15:
> eventSender.mouseMoveTo(10, 10);
> > On 2016/02/24 18:29:22, dcheng wrote:
> > > Where does the mouse start from? It it was already at (10, 10), does that
> mean
> > > no dragover event would ever fire?
> > 
> > last_mouse_pos is initialized as (0,0), no?
> 
> ok, just wanted to make sure it wouldn't end up depending on what test ran
> before it. lgtm

BlinkTestRunner is reset first, so it'll be back at (0,0).

[Rick Byers, 2016-02-24 19:08:59]

RS LGTM (dcheng@ is the expert)

[sof, 2016-02-24 20:14:24]

Description was changed from

==========
Have EventSender mouseups unwind better on cancellation during dragover.

Follow up on changes brought by r376733 and check if handling of dragover
cancelled our ongoing drag. Leave early, if so.

R=
BUG=589426
==========

to

==========
Have EventSender mouseups unwind better on cancellation during dragover.

Follow up on changes brought by r376733 and check if handling of dragover
cancelled our ongoing drag. Leave early, if so.

R=dcheng,rbyers
BUG=589426
==========

[sof, 2016-02-24 20:14:43]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-02-24 20:17:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1728353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1728353002/1

[commit-bot: I haz the power, 2016-02-24 21:29:54]

Description was changed from

==========
Have EventSender mouseups unwind better on cancellation during dragover.

Follow up on changes brought by r376733 and check if handling of dragover
cancelled our ongoing drag. Leave early, if so.

R=dcheng,rbyers
BUG=589426
==========

to

==========
Have EventSender mouseups unwind better on cancellation during dragover.

Follow up on changes brought by r376733 and check if handling of dragover
cancelled our ongoing drag. Leave early, if so.

R=dcheng,rbyers
BUG=589426
==========

[commit-bot: I haz the power, 2016-02-24 21:29:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-24 21:30:51]

Description was changed from

==========
Have EventSender mouseups unwind better on cancellation during dragover.

Follow up on changes brought by r376733 and check if handling of dragover
cancelled our ongoing drag. Leave early, if so.

R=dcheng,rbyers
BUG=589426
==========

to

==========
Have EventSender mouseups unwind better on cancellation during dragover.

Follow up on changes brought by r376733 and check if handling of dragover
cancelled our ongoing drag. Leave early, if so.

R=dcheng,rbyers
BUG=589426

Committed: https://crrev.com/8d568b12722f02dbb2ec358ce4600b96a673c481
Cr-Commit-Position: refs/heads/master@{#377392}
==========

[commit-bot: I haz the power, 2016-02-24 21:30:52]

Patchset 1 (id:??) landed as
https://crrev.com/8d568b12722f02dbb2ec358ce4600b96a673c481
Cr-Commit-Position: refs/heads/master@{#377392}