third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html - Issue 1728353002: Have EventSender mouseups unwind better on cancellation during dragover.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover.html

Issue 1728353002: Have EventSender mouseups unwind better on cancellation during dragover. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/test_runner/event_sender.cc ('k') | third_party/WebKit/LayoutTests/fast/events/drag-nested-eventSender-on-dragover-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script>

	4 if (window.testRunner)

	5 testRunner.dumpAsText();

	6

	7 document.addEventListener("dragover", function () {

	8 try {

	9 eventSender.beginDragWithFiles(["resources/empty.html"]);

	10 console.log("FAIL - nested beginDragWithFiles() expected to throw.");

	11 } catch (e) {;}

	12 });

	13

	14 eventSender.beginDragWithFiles(["resources/empty.html"]);

	15 eventSender.mouseMoveTo(10, 10);
	dcheng 2016/02/24 18:29:22 Where does the mouse start from? It it was already Where does the mouse start from? It it was already at (10, 10), does that mean no dragover event would ever fire? sof 2016/02/24 18:39:01 last_mouse_pos is initialized as (0,0), no? Show quoted text On 2016/02/24 18:29:22, dcheng wrote: > Where does the mouse start from? It it was already at (10, 10), does that mean > no dragover event would ever fire? last_mouse_pos is initialized as (0,0), no?
	16 eventSender.mouseUp();

	17 </script>

	18 <script src="../../resources/js-test.js"></script>

	19 <script>

	20 description('Test that nested use of eventSender.beginDragWithFiles() from withi n \|dragover\| is handled without crashing.');

	21 </script>

	22 </body>

OLD	NEW