third_party/WebKit/Source/core/layout/LayoutVideo.h - Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutVideo.h

Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and reflect comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ImageResourceObserver.h ('K') | « third_party/WebKit/Source/core/layout/LayoutTableSection.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutVideo.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutVideo.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutVideo.h b/third_party/WebKit/Source/core/layout/LayoutVideo.h

index 03d3efec29513161a0cad25d1d28561419af8b37..c098ec2b73f7b95892f40cfe18317e023a43d69a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutVideo.h

+++ b/third_party/WebKit/Source/core/layout/LayoutVideo.h

@@ -55,7 +55,7 @@ private:

LayoutSize calculateIntrinsicSize();

void updateIntrinsicSize();

- void imageChanged(WrappedImagePtr, const IntRect*) override;

+ void imageChanged(bool isNotifyingFinish, WrappedImagePtr, const IntRect*) override;

bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectVideo || LayoutMedia::isOfType(type); }