third_party/WebKit/Source/core/layout/LayoutVideo.cpp - Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutVideo.cpp

Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and reflect comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ImageResourceObserver.h ('K') | « third_party/WebKit/Source/core/layout/LayoutVideo.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutVideo.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp b/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

index 7c04530985119d4ff3801ab74874bbe0b6a7e542..a3826207b660b9b8e7e35d0002423c566beaf22f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

@@ -109,9 +109,9 @@ LayoutSize LayoutVideo::calculateIntrinsicSize()

return defaultSize();

}

-void LayoutVideo::imageChanged(WrappedImagePtr newImage, const IntRect* rect)

+void LayoutVideo::imageChanged(bool isNotifyingFinish, WrappedImagePtr newImage, const IntRect* rect)

{

- LayoutMedia::imageChanged(newImage, rect);

+ LayoutMedia::imageChanged(isNotifyingFinish, newImage, rect);

// Cache the image intrinsic size so we can continue to use it to draw the image correctly

// even if we know the video intrinsic size but aren't able to draw video frames yet