third_party/WebKit/Source/core/css/CSSCrossfadeValue.h - Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCrossfadeValue.h

Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and reflect comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSCrossfadeValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSCrossfadeValue.h b/third_party/WebKit/Source/core/css/CSSCrossfadeValue.h

index dbb0c436be3055bb7023de9f8d9d09eecabf9926..d32a21f29825b7cc45d39f0b792cbdbeaa9a56b6 100644

--- a/third_party/WebKit/Source/core/css/CSSCrossfadeValue.h

+++ b/third_party/WebKit/Source/core/css/CSSCrossfadeValue.h

@@ -87,7 +87,7 @@ private:

visitor->trace(m_ownerValue);

}

- void imageChanged(ImageResource*, const IntRect* = nullptr) override;

+ void imageChanged(bool, ImageResource*, const IntRect* = nullptr) override;

esprehn 2016/03/22 23:31:49 what's the argument? bool should have a name.

hiroshige 2016/03/24 17:26:44 Removed the parameter.

String debugName() const override { return "CrossfadeSubimageObserverProxy"; }

void setReady(bool ready) { m_ready = ready; }

private:

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp » ('j') | third_party/WebKit/Source/core/fetch/ImageResource.cpp » ('J')