Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSCrossfadeValue.h

Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and reflect comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 explicit CrossfadeSubimageObserverProxy(CSSCrossfadeValue* ownerValue) 80 explicit CrossfadeSubimageObserverProxy(CSSCrossfadeValue* ownerValue)
81 : m_ownerValue(ownerValue) 81 : m_ownerValue(ownerValue)
82 , m_ready(false) { } 82 , m_ready(false) { }
83 83
84 ~CrossfadeSubimageObserverProxy() override { } 84 ~CrossfadeSubimageObserverProxy() override { }
85 DEFINE_INLINE_TRACE() 85 DEFINE_INLINE_TRACE()
86 { 86 {
87 visitor->trace(m_ownerValue); 87 visitor->trace(m_ownerValue);
88 } 88 }
89 89
90 void imageChanged(ImageResource*, const IntRect* = nullptr) override; 90 void imageChanged(bool, ImageResource*, const IntRect* = nullptr) overri de;
esprehn 2016/03/22 23:31:49 what's the argument? bool should have a name.
hiroshige 2016/03/24 17:26:44 Removed the parameter.
91 String debugName() const override { return "CrossfadeSubimageObserverPro xy"; } 91 String debugName() const override { return "CrossfadeSubimageObserverPro xy"; }
92 void setReady(bool ready) { m_ready = ready; } 92 void setReady(bool ready) { m_ready = ready; }
93 private: 93 private:
94 RawPtrWillBeMember<CSSCrossfadeValue> m_ownerValue; 94 RawPtrWillBeMember<CSSCrossfadeValue> m_ownerValue;
95 bool m_ready; 95 bool m_ready;
96 }; 96 };
97 97
98 void crossfadeChanged(const IntRect&); 98 void crossfadeChanged(const IntRect&);
99 99
100 RefPtrWillBeMember<CSSValue> m_fromValue; 100 RefPtrWillBeMember<CSSValue> m_fromValue;
101 RefPtrWillBeMember<CSSValue> m_toValue; 101 RefPtrWillBeMember<CSSValue> m_toValue;
102 RefPtrWillBeMember<CSSPrimitiveValue> m_percentageValue; 102 RefPtrWillBeMember<CSSPrimitiveValue> m_percentageValue;
103 103
104 RefPtrWillBeMember<ImageResource> m_cachedFromImage; 104 RefPtrWillBeMember<ImageResource> m_cachedFromImage;
105 RefPtrWillBeMember<ImageResource> m_cachedToImage; 105 RefPtrWillBeMember<ImageResource> m_cachedToImage;
106 106
107 RefPtr<Image> m_generatedImage; 107 RefPtr<Image> m_generatedImage;
108 108
109 CrossfadeSubimageObserverProxy m_crossfadeSubimageObserver; 109 CrossfadeSubimageObserverProxy m_crossfadeSubimageObserver;
110 }; 110 };
111 111
112 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCrossfadeValue, isCrossfadeValue()); 112 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCrossfadeValue, isCrossfadeValue());
113 113
114 } // namespace blink 114 } // namespace blink
115 115
116 #endif // CSSCrossfadeValue_h 116 #endif // CSSCrossfadeValue_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698