third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp - Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

Issue 1728313003: Split ImageResourceClient into ResourceClient and ImageResourceObserver [2/2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and reflect comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSCrossfadeValue.h ('K') | « third_party/WebKit/Source/core/css/CSSCrossfadeValue.h ('k') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('j') | third_party/WebKit/Source/core/fetch/ImageResource.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp b/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

index cad9c3e3a671a6ec8e1bdbdb69c67161db8ef3a7..07e38e5f17f1e64ff2813bb1ecbcc8f98b2be415 100644

--- a/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp

@@ -252,11 +252,11 @@ void CSSCrossfadeValue::crossfadeChanged(const IntRect&)

{

for (const auto& curr : clients()) {

LayoutObject* client = const_cast<LayoutObject*>(curr.key);

- client->imageChanged(static_cast<WrappedImagePtr>(this));

+ client->imageChanged(false, static_cast<WrappedImagePtr>(this));

}

-void CSSCrossfadeValue::CrossfadeSubimageObserverProxy::imageChanged(ImageResource*, const IntRect* rect)

+void CSSCrossfadeValue::CrossfadeSubimageObserverProxy::imageChanged(bool, ImageResource*, const IntRect* rect)

{

if (m_ready)

m_ownerValue->crossfadeChanged(*rect);