Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1728093007: Make Event.deepPath() return an empty array if an event is no longer being dispatched (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
yuzuchan, kochi
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Event.deepPath() return an empty array if an event is no longer being dispatched The spec discussion is: https://github.com/w3c/webcomponents/issues/373 BUG=531990 Committed: https://crrev.com/e7f0f3efe8ec0b9487809382dc3c3190d01025f0 Cr-Commit-Position: refs/heads/master@{#377563}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path-empty.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093007/1
4 years, 10 months ago (2016-02-25 07:36:58 UTC) #2
hayato
PTAL
4 years, 10 months ago (2016-02-25 07:50:17 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/186732)
4 years, 10 months ago (2016-02-25 08:41:09 UTC) #7
kochi
lgtm with nit. https://codereview.chromium.org/1728093007/diff/1/third_party/WebKit/Source/core/events/Event.h File third_party/WebKit/Source/core/events/Event.h (right): https://codereview.chromium.org/1728093007/diff/1/third_party/WebKit/Source/core/events/Event.h#newcode250 third_party/WebKit/Source/core/events/Event.h:250: WillBeHeapVector<RefPtrWillBeMember<EventTarget>> pathInternal(ScriptState*, EventPathMode) const; nit: usually ...
4 years, 10 months ago (2016-02-25 09:49:40 UTC) #8
hayato
update
4 years, 10 months ago (2016-02-25 10:22:41 UTC) #10
hayato
https://codereview.chromium.org/1728093007/diff/1/third_party/WebKit/Source/core/events/Event.h File third_party/WebKit/Source/core/events/Event.h (right): https://codereview.chromium.org/1728093007/diff/1/third_party/WebKit/Source/core/events/Event.h#newcode250 third_party/WebKit/Source/core/events/Event.h:250: WillBeHeapVector<RefPtrWillBeMember<EventTarget>> pathInternal(ScriptState*, EventPathMode) const; On 2016/02/25 09:49:40, kochi wrote: ...
4 years, 10 months ago (2016-02-25 10:22:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728093007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728093007/20001
4 years, 10 months ago (2016-02-25 10:23:53 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 13:11:20 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 13:12:46 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7f0f3efe8ec0b9487809382dc3c3190d01025f0
Cr-Commit-Position: refs/heads/master@{#377563}

Powered by Google App Engine
This is Rietveld 408576698