third_party/WebKit/Source/core/events/Event.h - Issue 1728093007: Make Event.deepPath() return an empty array if an event is no longer being dispatched

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/Event.h

Issue 1728093007: Make Event.deepPath() return an empty array if an event is no longer being dispatched (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/event-deep-path-empty.html ('k') | third_party/WebKit/Source/core/events/Event.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/Event.h

diff --git a/third_party/WebKit/Source/core/events/Event.h b/third_party/WebKit/Source/core/events/Event.h

index e447f5d3372663c4dcb7d470fa593c6cb6200c7d..ab661b86a34760bbb31f99743b9d4e20d4a74200 100644

--- a/third_party/WebKit/Source/core/events/Event.h

+++ b/third_party/WebKit/Source/core/events/Event.h

@@ -187,6 +187,7 @@ public:

void initEventPath(Node&);

WillBeHeapVector<RefPtrWillBeMember<EventTarget>> path(ScriptState*) const;

+ WillBeHeapVector<RefPtrWillBeMember<EventTarget>> deepPath(ScriptState*) const;

bool isBeingDispatched() const { return eventPhase(); }

@@ -217,6 +218,13 @@ protected:

void setCanBubble(bool bubble) { m_canBubble = bubble; }

private:

+ enum EventPathMode {

+ EmptyAfterDispatch,

+ NonEmptyAfterDispatch

+ };

+ WillBeHeapVector<RefPtrWillBeMember<EventTarget>> pathInternal(ScriptState*, EventPathMode) const;

AtomicString m_type;

unsigned m_canBubble:1;

unsigned m_cancelable:1;