Extract a Connector interface from Shell that can be cloned & passed to other threads

One feature of MojoShellContext in content is that Connect() can be called from any thread. If we want to replace this class we need this ability in the Mojo Shell client lib too. To this end I've extracted the Connect() method to its own interface which can be constructed from Shell. This interface can be cloned and passed on to other threads also.

R=sky@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1a1f457e6c1d5ad1bc8816e443f3f7e2fe037333
Cr-Commit-Position: refs/heads/master@{#377407}

[Ben Goodger (Google), 2016-02-24 05:44:26]

Description was changed from

==========
connector

BUG=
==========

to

==========
One feature of MojoShellContext in content is that Connect() can be called from
any thread. If we want to replace this class we need this ability in the Mojo
Shell client lib too. To this end I've extracted the Connect() method to its own
interface which can be constructed from Shell. This interface can be cloned and
passed on to other threads also.

R=sky@chromium.org
BUG=
==========

[Ben Goodger (Google), 2016-02-24 05:44:26]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[Ben Goodger (Google), 2016-02-24 06:12:49]

Description was changed from

==========
One feature of MojoShellContext in content is that Connect() can be called from
any thread. If we want to replace this class we need this ability in the Mojo
Shell client lib too. To this end I've extracted the Connect() method to its own
interface which can be constructed from Shell. This interface can be cloned and
passed on to other threads also.

R=sky@chromium.org
BUG=
==========

to

==========
One feature of MojoShellContext in content is that Connect() can be called from
any thread. If we want to replace this class we need this ability in the Mojo
Shell client lib too. To this end I've extracted the Connect() method to its own
interface which can be constructed from Shell. This interface can be cloned and
passed on to other threads also.

R=sky@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[sky, 2016-02-24 17:08:07]

https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/cpp/...
File mojo/shell/public/cpp/connector.h (right):

https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/cpp/...
mojo/shell/public/cpp/connector.h:30: explicit ConnectParams(const std::string&
url);
How come this takes a string rather than a GURL?

https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/cpp/...
mojo/shell/public/cpp/connector.h:57: virtual scoped_ptr<Connection>
Connect(const std::string& url) = 0;
Similar comment about string vs GURL.

https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/cpp/...
File mojo/shell/public/cpp/lib/connector_impl.cc (right):

https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/cpp/...
mojo/shell/public/cpp/lib/connector_impl.cc:35:
connector_.Bind(std::move(unbound_state_));
It would be good if you add threadchecker to assert calls happen on the right
thread.

https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/inte...
File mojo/shell/public/interfaces/shell.mojom (right):

https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/inte...
mojo/shell/public/interfaces/shell.mojom:93: GetConnector(Connector& connector);
One thing not readily obvious from this api is that the implementation of
connector is tied to the life of the applicationinstance. I think you should say
that.

[Ben Goodger (Google), 2016-02-24 19:03:23]

On 2016/02/24 17:08:07, sky wrote:
>
https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/cpp/...
> File mojo/shell/public/cpp/connector.h (right):
> 
>
https://codereview.chromium.org/1728083002/diff/140001/mojo/shell/public/cpp/...
> mojo/shell/public/cpp/connector.h:30: explicit ConnectParams(const
std::string&
> url);
> How come this takes a string rather than a GURL?

We need to dispel this fiction that mojo: URLs are real URLs. They are not real
URLs.
(I've added a TODO to my tasklist to complete this on the service side).

All else updated. PTAL.

[sky, 2016-02-24 19:23:31]

LGTM

[Ben Goodger (Google), 2016-02-24 20:30:28]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-24 20:35:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1728083002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1728083002/180001

[commit-bot: I haz the power, 2016-02-24 22:17:32]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-02-24 22:19:50]

Description was changed from

==========
One feature of MojoShellContext in content is that Connect() can be called from
any thread. If we want to replace this class we need this ability in the Mojo
Shell client lib too. To this end I've extracted the Connect() method to its own
interface which can be constructed from Shell. This interface can be cloned and
passed on to other threads also.

R=sky@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
One feature of MojoShellContext in content is that Connect() can be called from
any thread. If we want to replace this class we need this ability in the Mojo
Shell client lib too. To this end I've extracted the Connect() method to its own
interface which can be constructed from Shell. This interface can be cloned and
passed on to other threads also.

R=sky@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1a1f457e6c1d5ad1bc8816e443f3f7e2fe037333
Cr-Commit-Position: refs/heads/master@{#377407}
==========

[commit-bot: I haz the power, 2016-02-24 22:19:51]

Patchset 10 (id:??) landed as
https://crrev.com/1a1f457e6c1d5ad1bc8816e443f3f7e2fe037333
Cr-Commit-Position: refs/heads/master@{#377407}