Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1734643003: Remove CapabilityFilter from Connect() (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@13connector2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CapabilityFilter from Connect() It's supplied by the package manifest now so isn't needed for every Connect() call. BTW it's still passed for CreateInstanceForHandle() (can't see a way around that, yet). This disables the CapabilityFilter tests which assume that this works, I need to rewrite all the shell tests now it's completely different. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/0a390e6b9f4c6d11ffbd61d0828adc1b2f1aafef Cr-Commit-Position: refs/heads/master@{#377502}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -116 lines) Patch
M content/browser/frame_host/frame_mojo_shell.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/frame_mojo_shell.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/test/data/web_ui_mojo_shell_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/application_instance.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/shell/application_instance.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 3 chunks +10 lines, -10 lines 0 comments Download
M mojo/shell/background/background_shell.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M mojo/shell/connect_params.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/shell/connect_params.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/shell/connect_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/identity.h View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/shell/identity.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M mojo/shell/public/cpp/connector.h View 3 chunks +0 lines, -10 lines 0 comments Download
M mojo/shell/public/cpp/lib/connector_impl.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M mojo/shell/public/cpp/shell.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 2 chunks +1 line, -5 lines 0 comments Download
M mojo/shell/standalone/context.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M mojo/shell/tests/application_manager_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/tests/capability_filter_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/capability_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (13 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-24 22:16:51 UTC) #4
sky
LGTM
4 years, 10 months ago (2016-02-24 22:22:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734643003/1
4 years, 10 months ago (2016-02-24 22:26:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734643003/20001
4 years, 10 months ago (2016-02-24 22:35:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/120859)
4 years, 10 months ago (2016-02-24 22:43:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734643003/20001
4 years, 10 months ago (2016-02-24 23:58:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/120934) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-25 00:38:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734643003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734643003/30001
4 years, 10 months ago (2016-02-25 02:51:04 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 10 months ago (2016-02-25 04:14:57 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 04:16:58 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a390e6b9f4c6d11ffbd61d0828adc1b2f1aafef
Cr-Commit-Position: refs/heads/master@{#377502}

Powered by Google App Engine
This is Rietveld 408576698