src/full-codegen/mips/full-codegen-mips.cc - Issue 1727953004: [fullcodegen] Factor out EmitLoadStoreICSlot from archs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1727953004: [fullcodegen] Factor out EmitLoadStoreICSlot from archs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/mips/full-codegen-mips.cc

diff --git a/src/full-codegen/mips/full-codegen-mips.cc b/src/full-codegen/mips/full-codegen-mips.cc

index 55484123c82175e4256a7865c76a46cbe15f1d49..0db266c34f47163d33fc33a87134c48245662044 100644

--- a/src/full-codegen/mips/full-codegen-mips.cc

+++ b/src/full-codegen/mips/full-codegen-mips.cc

@@ -4109,12 +4109,6 @@ void FullCodeGenerator::ClearPendingMessage() {

}

-void FullCodeGenerator::EmitLoadStoreICSlot(FeedbackVectorSlot slot) {

- DCHECK(!slot.IsInvalid());

- __ li(VectorStoreICTrampolineDescriptor::SlotRegister(),

- Operand(SmiFromSlot(slot)));

void FullCodeGenerator::DeferredCommands::EmitCommands() {

DCHECK(!result_register().is(a1));

__ Pop(result_register()); // Restore the accumulator.