src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1727953004: [fullcodegen] Factor out EmitLoadStoreICSlot from archs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1727953004: [fullcodegen] Factor out EmitLoadStoreICSlot from archs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 25744dcdc1346d752e880bf53d71fcd6ed15e46e..ee9c3c433b1fb2948884c1a0cb62592dc9c4b6c7 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -3986,12 +3986,6 @@ void FullCodeGenerator::ClearPendingMessage() {

}

-void FullCodeGenerator::EmitLoadStoreICSlot(FeedbackVectorSlot slot) {

- DCHECK(!slot.IsInvalid());

- __ mov(VectorStoreICTrampolineDescriptor::SlotRegister(),

- Immediate(SmiFromSlot(slot)));

void FullCodeGenerator::DeferredCommands::EmitCommands() {

DCHECK(!result_register().is(edx));

__ Pop(result_register()); // Restore the accumulator.

« no previous file with comments | « src/full-codegen/full-codegen.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »