Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1727953004: [fullcodegen] Factor out EmitLoadStoreICSlot from archs. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Factor out EmitLoadStoreICSlot from archs. R=mvstanton@chromium.org Committed: https://crrev.com/64350d7f0dbef0d7ea11850dcf201110a8549f0e Cr-Commit-Position: refs/heads/master@{#34486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -48 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/full-codegen/full-codegen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-25 10:02:46 UTC) #1
mvstanton
Sorry to miss this one! LGTM.
4 years, 9 months ago (2016-03-02 21:43:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727953004/1
4 years, 9 months ago (2016-03-04 09:21:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 09:42:39 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 09:44:10 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/64350d7f0dbef0d7ea11850dcf201110a8549f0e
Cr-Commit-Position: refs/heads/master@{#34486}

Powered by Google App Engine
This is Rietveld 408576698