aw: Do not assume functor will be called on UI thread

aw: Do not assume functor will be called on UI thread

Instead save the thread of the DrawGL call and use that to determine if
GL is allowed. Not that RequestGL and most other things still run on UI
thread.

No thread safety added in this change.

BUG=344087
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252285

[boliu, 2014-02-19 19:12:10]

Depends on https://codereview.chromium.org/170283013/ to land first.

[no sievers, 2014-02-19 21:12:19]

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/gl_v...
File android_webview/browser/gl_view_renderer_manager.cc (right):

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/gl_v...
android_webview/browser/gl_view_renderer_manager.cc:16: bool
GLViewRendererManager::OnRenderThread() const {
You probably want a lock here and in MarkRenderThread().

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
File android_webview/browser/in_process_view_renderer.cc (left):

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
android_webview/browser/in_process_view_renderer.cc:165:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
Should we keep this check?

[boliu, 2014-02-19 21:33:40]

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/gl_v...
File android_webview/browser/gl_view_renderer_manager.cc (right):

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/gl_v...
android_webview/browser/gl_view_renderer_manager.cc:16: bool
GLViewRendererManager::OnRenderThread() const {
On 2014/02/19 21:12:19, sievers wrote:
> You probably want a lock here and in MarkRenderThread().

Done.

Actually this whole class will need to be protected by a lock since
DidDrawGL/NoLongerExpectsDrawGL will (probably) happen on RT, but
GetMostRecentlyDrawn will definitely be on UI thread.

InProcessViewRenderer itself is still not thread safe, but not dealing with that
yet.

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
File android_webview/browser/in_process_view_renderer.cc (left):

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
android_webview/browser/in_process_view_renderer.cc:165:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
On 2014/02/19 21:12:19, sievers wrote:
> Should we keep this check?

No. This will be called on render thread.

[no sievers, 2014-02-19 21:36:30]

lgtm

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
File android_webview/browser/in_process_view_renderer.cc (left):

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
android_webview/browser/in_process_view_renderer.cc:165:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
On 2014/02/19 21:33:40, boliu wrote:
> On 2014/02/19 21:12:19, sievers wrote:
> > Should we keep this check?
> 
> No. This will be called on render thread.

I meant the idea of the check :)
I.e. DCHECK(g_view_renderer_manager.Get().OnRenderThread());

[boliu, 2014-02-19 21:39:56]

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
File android_webview/browser/in_process_view_renderer.cc (left):

https://codereview.chromium.org/172793002/diff/1/android_webview/browser/in_p...
android_webview/browser/in_process_view_renderer.cc:165:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
On 2014/02/19 21:36:30, sievers wrote:
> On 2014/02/19 21:33:40, boliu wrote:
> > On 2014/02/19 21:12:19, sievers wrote:
> > > Should we keep this check?
> > 
> > No. This will be called on render thread.
> 
> I meant the idea of the check :)
> I.e. DCHECK(g_view_renderer_manager.Get().OnRenderThread());

Aha! Done.

[boliu, 2014-02-20 01:50:43]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-02-20 02:08:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/172793002/150001

[commit-bot: I haz the power, 2014-02-20 05:19:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/172793002/150001

[commit-bot: I haz the power, 2014-02-20 09:19:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/172793002/150001

[commit-bot: I haz the power, 2014-02-20 12:35:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/172793002/150001

[commit-bot: I haz the power, 2014-02-20 17:17:05]

Change committed as 252285