aw: Do not assume functor will be called on UI thread

android_webview/browser/gl_view_renderer_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/gl_view_renderer_manager.h"
 
 #include "base/logging.h"
+#include "base/threading/platform_thread.h"
 
 namespace android_webview {
 
 GLViewRendererManager::GLViewRendererManager() {}
 
 GLViewRendererManager::~GLViewRendererManager() {}
 
+bool GLViewRendererManager::OnRenderThread() const {

[no sievers, 2014/02/19 21:12:19]

You probably want a lock here and in MarkRenderThread().

[boliu, 2014/02/19 21:33:40]

Done.

Actually this whole class will need to be protected by a lock since
DidDrawGL/NoLongerExpectsDrawGL will (probably) happen on RT, but
GetMostRecentlyDrawn will definitely be on UI thread.

InProcessViewRenderer itself is still not thread safe, but not dealing with that
yet.

+  return render_thread_.is_equal(base::PlatformThread::CurrentHandle());
+}
+
+void GLViewRendererManager::MarkRenderThread() {
+  if (render_thread_.is_null())
+    render_thread_ = base::PlatformThread::CurrentHandle();
+  DCHECK(OnRenderThread());
+}
+
 GLViewRendererManager::Key GLViewRendererManager::DidDrawGL(
     Key key,
     BrowserViewRenderer* view) {
+  MarkRenderThread();
+
   if (key == mru_list_.end()) {
     DCHECK(mru_list_.end() ==
            std::find(mru_list_.begin(), mru_list_.end(), view));
     mru_list_.push_front(view);
     return mru_list_.begin();
   } else {
     DCHECK(*key == view);
     mru_list_.splice(mru_list_.begin(), mru_list_, key);
     return key;
   }
 }
 
 void GLViewRendererManager::NoLongerExpectsDrawGL(Key key) {
   DCHECK(mru_list_.end() != key);
   mru_list_.erase(key);
 }
 
 BrowserViewRenderer* GLViewRendererManager::GetMostRecentlyDrawn() const {
   if (mru_list_.begin() == mru_list_.end())
     return NULL;
   return *mru_list_.begin();
 }
 
 GLViewRendererManager::Key GLViewRendererManager::NullKey() {
   return mru_list_.end();
 }
 
 }  // namespace android_webview