Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1727873003: [crankshaft] Fix deopt loop in String.fromCharCode on non-int32 inputs. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix deopt loop in String.fromCharCode on non-int32 inputs. The Crankshaft fast case for String.fromCharCode() unconditionally deoptimizes on all non-int32 inputs, even tho it would be perfectly valid to just truncate the index to an int32. R=ishell@chromium.org BUG=chromium:587068 LOG=n Committed: https://crrev.com/6cc5c601b66e3ce95e66e16e4be9ac0c3b1ea433 Cr-Commit-Position: refs/heads/master@{#34243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-587068.js View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-24 10:35:59 UTC) #1
Benedikt Meurer
Hey Igor, Simple fix for the deopt loop w/ String.fromCharCode. Please take a look. Thanks, ...
4 years, 10 months ago (2016-02-24 10:36:46 UTC) #2
Igor Sheludko
lgtm
4 years, 10 months ago (2016-02-24 10:40:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727873003/1
4 years, 10 months ago (2016-02-24 10:40:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 10:59:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 11:00:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cc5c601b66e3ce95e66e16e4be9ac0c3b1ea433
Cr-Commit-Position: refs/heads/master@{#34243}

Powered by Google App Engine
This is Rietveld 408576698