Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 1727873003: [crankshaft] Fix deopt loop in String.fromCharCode on non-int32 inputs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-587068.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/allocation-site-scopes.h" 9 #include "src/allocation-site-scopes.h"
10 #include "src/ast/ast-numbering.h" 10 #include "src/ast/ast-numbering.h"
(...skipping 8773 matching lines...) Expand 10 before | Expand all | Expand 10 after
8784 AddInstruction(char_code); 8784 AddInstruction(char_code);
8785 HInstruction* result = NewUncasted<HStringCharFromCode>(char_code); 8785 HInstruction* result = NewUncasted<HStringCharFromCode>(char_code);
8786 ast_context()->ReturnInstruction(result, expr->id()); 8786 ast_context()->ReturnInstruction(result, expr->id());
8787 return true; 8787 return true;
8788 } 8788 }
8789 break; 8789 break;
8790 case kStringFromCharCode: 8790 case kStringFromCharCode:
8791 if (argument_count == 2) { 8791 if (argument_count == 2) {
8792 HValue* argument = Pop(); 8792 HValue* argument = Pop();
8793 Drop(2); // Receiver and function. 8793 Drop(2); // Receiver and function.
8794 argument = AddUncasted<HForceRepresentation>(
8795 argument, Representation::Integer32());
8796 argument->SetFlag(HValue::kTruncatingToInt32);
8794 HInstruction* result = NewUncasted<HStringCharFromCode>(argument); 8797 HInstruction* result = NewUncasted<HStringCharFromCode>(argument);
8795 ast_context()->ReturnInstruction(result, expr->id()); 8798 ast_context()->ReturnInstruction(result, expr->id());
8796 return true; 8799 return true;
8797 } 8800 }
8798 break; 8801 break;
8799 case kMathExp: 8802 case kMathExp:
8800 if (!FLAG_fast_math) break; 8803 if (!FLAG_fast_math) break;
8801 // Fall through if FLAG_fast_math. 8804 // Fall through if FLAG_fast_math.
8802 case kMathRound: 8805 case kMathRound:
8803 case kMathFround: 8806 case kMathFround:
(...skipping 4664 matching lines...) Expand 10 before | Expand all | Expand 10 after
13468 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13471 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13469 } 13472 }
13470 13473
13471 #ifdef DEBUG 13474 #ifdef DEBUG
13472 graph_->Verify(false); // No full verify. 13475 graph_->Verify(false); // No full verify.
13473 #endif 13476 #endif
13474 } 13477 }
13475 13478
13476 } // namespace internal 13479 } // namespace internal
13477 } // namespace v8 13480 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-587068.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698