components/security_state/security_state_model.h - Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_state/security_state_model.h

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments; simplify a lot of the strings; take out IsObsoleteTLSCipherSuite(). Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/ui/website_settings/website_settings.cc ('k') | components/security_state/security_state_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_state/security_state_model.h

diff --git a/components/security_state/security_state_model.h b/components/security_state/security_state_model.h

index 26dd220648771eb238c37d781d9f4739fc51ebed..f6b5212e8733ed7853a75da89b3cd598a2dcc9d5 100644

--- a/components/security_state/security_state_model.h

+++ b/components/security_state/security_state_model.h

@@ -104,9 +104,10 @@ class SecurityStateModel {

// Information about the SSL connection, such as protocol and

// ciphersuite. See ssl_connection_flags.h in net.

int connection_status;

- // True if the protocol version and ciphersuite for the connection

- // are considered secure.

- bool is_secure_protocol_and_ciphersuite;

+ // A mask that indicates which of the protocol version,

+ // key exchange, or cipher for the connection is considered

+ // obsolete. See net::ObsoleteSSLMask for specific mask values.

+ int obsolete_ssl_status;

};

// Contains the security state relevant to computing the SecurityInfo