components/security_state/security_state_model.cc - Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_state/security_state_model.cc

Issue 1727133002: Expose TLS settings in the Security panel overview, and call out individual obsolete settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments; simplify a lot of the strings; take out IsObsoleteTLSCipherSuite(). Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « components/security_state/security_state_model.h ('k') | content/browser/devtools/protocol/security_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_state/security_state_model.cc

diff --git a/components/security_state/security_state_model.cc b/components/security_state/security_state_model.cc

index 2efa11c02c8277b886a1294a80306688fc4bb599..1bb79c413eba2761b117e2c89a68e64d63b4f109 100644

--- a/components/security_state/security_state_model.cc

+++ b/components/security_state/security_state_model.cc

@@ -184,12 +184,8 @@ void SecurityInfoForRequest(

security_info->cert_status = visible_security_state.cert_status;

security_info->scheme_is_cryptographic =

visible_security_state.url.SchemeIsCryptographic();

- security_info->is_secure_protocol_and_ciphersuite =

- (net::SSLConnectionStatusToVersion(security_info->connection_status) >=

- net::SSL_CONNECTION_VERSION_TLS1_2 &&

- net::IsSecureTLSCipherSuite(net::SSLConnectionStatusToCipherSuite(

- security_info->connection_status)));

+ security_info->obsolete_ssl_status =

+ net::ObsoleteSSLStatus(security_info->connection_status);

security_info->sct_verify_statuses =

visible_security_state.sct_verify_statuses;

@@ -217,7 +213,7 @@ SecurityStateModel::SecurityInfo::SecurityInfo()

cert_id(0),

security_bits(-1),

connection_status(0),

- is_secure_protocol_and_ciphersuite(false) {}

+ obsolete_ssl_status(net::OBSOLETE_SSL_NONE) {}

SecurityStateModel::SecurityInfo::~SecurityInfo() {}