Clean up *.in files related to DOM exceptions and events

Clean up *.in files related to DOM exceptions and events

- Remove confusing interfaceName and JSInterfaceName arguments
- Introduce implementedAs argument that matches [ImplementedAs] on
  Web IDL side
- The name of each entry now matches the interface name on Web IDL
  side and therefore the name exposed to JavaScript
- Add path information missing for several entries
- Sort entries alphabetically
- Fix name_macros.py script to stop generating duplicate header
  includes (e.g. "Event.h" / "V8Event.h" were included a lot in the
  generated EventHeaders.h

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152557

[haraken, 2013-06-17 13:38:37]

LGTM with comments.

https://codereview.chromium.org/17271002/diff/1/Source/core/dom/DOMExceptions.in
File Source/core/dom/DOMExceptions.in (right):

https://codereview.chromium.org/17271002/diff/1/Source/core/dom/DOMExceptions...
Source/core/dom/DOMExceptions.in:7: core/xml/XPathException

Would you sort everything in the alphabetical order? The same comment for other
.in files.

https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_dom_...
File Source/core/scripts/make_dom_exceptions.py (right):

https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_dom_...
Source/core/scripts/make_dom_exceptions.py:133: def _exception_class_name(self,
exception):

Can't you use _class_name_for_entry in name_macros.py? We want to share code as
much as possible by putting them into name_macros.py.

https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_even...
File Source/core/scripts/make_event_factory.py (right):

https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_even...
Source/core/scripts/make_event_factory.py:80: class_name =
event['implementedAs'] if event['implementedAs'] else name

Ditto. Can you use _class_name_for_entry in name_macros.py?

[do-not-use, 2013-06-17 14:29:59]

On 2013/06/17 13:38:37, haraken wrote:
> LGTM with comments.
> 
>
https://codereview.chromium.org/17271002/diff/1/Source/core/dom/DOMExceptions.in
> File Source/core/dom/DOMExceptions.in (right):
> 
>
https://codereview.chromium.org/17271002/diff/1/Source/core/dom/DOMExceptions...
> Source/core/dom/DOMExceptions.in:7: core/xml/XPathException
> 
> Would you sort everything in the alphabetical order? The same comment for
other
> .in files.
> 
>
https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_dom_...
> File Source/core/scripts/make_dom_exceptions.py (right):
> 
>
https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_dom_...
> Source/core/scripts/make_dom_exceptions.py:133: def
_exception_class_name(self,
> exception):
> 
> Can't you use _class_name_for_entry in name_macros.py? We want to share code
as
> much as possible by putting them into name_macros.py.
> 
>
https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_even...
> File Source/core/scripts/make_event_factory.py (right):
> 
>
https://codereview.chromium.org/17271002/diff/1/Source/core/scripts/make_even...
> Source/core/scripts/make_event_factory.py:80: class_name =
> event['implementedAs'] if event['implementedAs'] else name
> 
> Ditto. Can you use _class_name_for_entry in name_macros.py?

Thanks, I updated as per your comments.

[haraken, 2013-06-17 14:31:02]

LGTM

[haraken, 2013-06-17 14:33:50]

https://codereview.chromium.org/17271002/diff/8001/Source/core/dom/EventTarge...
File Source/core/dom/EventTargetFactory.in (right):

https://codereview.chromium.org/17271002/diff/8001/Source/core/dom/EventTarge...
Source/core/dom/EventTargetFactory.in:5: core/dom/WebKitNamedFlow
implementedAs=NamedFlow

Nit: alphabetical order please.

https://codereview.chromium.org/17271002/diff/8001/Source/core/dom/EventTarge...
Source/core/dom/EventTargetFactory.in:13: core/page/Window
implementedAs=DOMWindow

Nit: alphabetical order please.

[do-not-use, 2013-06-17 14:36:24]

https://codereview.chromium.org/17271002/diff/8001/Source/core/dom/EventTarge...
File Source/core/dom/EventTargetFactory.in (right):

https://codereview.chromium.org/17271002/diff/8001/Source/core/dom/EventTarge...
Source/core/dom/EventTargetFactory.in:5: core/dom/WebKitNamedFlow
implementedAs=NamedFlow
On 2013/06/17 14:33:50, haraken wrote:
> 
> Nit: alphabetical order please.

I forgot to check this file, sorry. I'll fix and reupload.

[commit-bot: I haz the power, 2013-06-17 14:56:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17271002/16001

[commit-bot: I haz the power, 2013-06-17 16:14:16]

Change committed as 152557

[abarth-chromium, 2013-06-17 18:24:50]

This looks great!  Thanks for doing this.