Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: Source/core/scripts/make_event_factory.py

Issue 17271002: Clean up *.in files related to DOM exceptions and events (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix order in EventTargetFactory.in Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/scripts/make_dom_exceptions.py ('k') | Source/core/scripts/name_macros.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/scripts/make_event_factory.py
diff --git a/Source/core/scripts/make_event_factory.py b/Source/core/scripts/make_event_factory.py
index cf6790ac2353295266861eb3a2f68b0529db0c38..06d0880fa151e940ec5b7c980809089ed0c054e4 100644
--- a/Source/core/scripts/make_event_factory.py
+++ b/Source/core/scripts/make_event_factory.py
@@ -57,8 +57,7 @@ PassRefPtr<%(class_name)s> %(class_name)sFactory::create(const String& type)
class EventFactoryWriter(name_macros.Writer):
defaults = {
- 'JSInterfaceName': None,
- 'interfaceName': None,
+ 'implementedAs': None,
'conditional': None,
'runtimeConditional': None,
}
@@ -78,12 +77,12 @@ class EventFactoryWriter(name_macros.Writer):
if event['runtimeConditional']:
runtime_condition = ' && RuntimeEnabledFeatures::' + event['runtimeConditional'] + '()'
name = os.path.basename(event['name'])
- interface_name = event['interfaceName'] if event['interfaceName'] else name
+ class_name = self._class_name_for_entry(event)
implementation = """ if (type == "%(name)s"%(runtime_condition)s)
- return %(interface_name)s::create();""" % {
+ return %(class_name)s::create();""" % {
'name': name,
'runtime_condition': runtime_condition,
- 'interface_name': interface_name,
+ 'class_name': class_name,
}
return self.wrap_with_condition(implementation, event['conditional'])
« no previous file with comments | « Source/core/scripts/make_dom_exceptions.py ('k') | Source/core/scripts/name_macros.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698