DescriptionRevert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #5 id:80001 of https://codereview.chromium.org/1711083002/ )
Reason for revert:
Regression: WebKit Linux Leak
Suspecting this cl for WebKit leak regression on Linux, from the list of cls suggested by Sheriff-o-matic ( https://chromium.googlesource.com/chromium/src/+log/b99fe46d578c03c48b58406628e27c4e0de7e0bf%5E..04f05e57fe272290b9ceddb288d919434277165e?pretty=fuller )
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak?numbuilds=50
Beginning in Build #17652 - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17652/steps/webkit_tests/logs/stdio
16:45:41.551 14179 worker/2 fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html output stderr lines:
16:45:41.551 14179 Xlib: extension "RANDR" missing on display ":9".
16:45:41.552 14179 Xlib: extension "RANDR" missing on display ":9".
16:45:41.552 14179 [31241:31241:0222/164540:1670209790:ERROR:object_proxy.cc(580)] Failed to call method: org.freedesktop.DBus.ObjectManager.GetManagedObjects: object_path= /: org.freedesktop.DBus.Error.UnknownMethod: Method "GetManagedObjects" with signature "" on interface "org.freedesktop.DBus.ObjectManager" doesn't exist
16:45:41.552 14179
16:45:41.552 14179 [31241:31241:0222/164540:1670210185:WARNING:object_manager.cc(370)] org.bluez /: Failed to get managed objects
16:45:41.552 14179 [31241:31241:0222/164540:1670212252:ERROR:object_proxy.cc(580)] Failed to call method: org.freedesktop.DBus.ObjectManager.GetManagedObjects: object_path= /: org.freedesktop.DBus.Error.UnknownMethod: Method "GetManagedObjects" with signature "" on interface "org.freedesktop.DBus.ObjectManager" doesn't exist
16:45:41.552 14179
16:45:41.552 14179 [31241:31241:0222/164540:1670212556:WARNING:object_manager.cc(370)] org.bluez /: Failed to get managed objects
16:45:41.552 14179 [31241:31349:0222/164540:1670222703:ERROR:zygote_host_impl_linux.cc(162)] Failed to adjust OOM score of renderer with pid 31366: Permission denied
16:45:41.582 14179 "/usr/bin/wdiff --help" took 0.03s
16:45:41.614 14179 "/usr/bin/wdiff --start-delete=##WDIFF_DEL## --end-delete=##WDIFF_END## --start-insert=##WDIFF_ADD## --end-insert=##WDIFF_END## /mnt/data/b/build/slave/WebKit_Linux_Leak/build/layout-test-results/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt /mnt/data/b/build/slave/WebKit_Linux_Leak/build/layout-test-results/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-actual.txt" took 0.03s
16:45:41.646 14179 "ruby --version" took 0.03s
.
.
.
Regressions: Unexpected text-only failures (1)
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html [ Failure Failure Failure Leak ]
Regressions: Unexpected leaks (2)
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html [ Leak Leak Failure Failure ]
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html [ Leak Leak Leak Failure ]
Original issue's description:
> [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator.
>
> This unifies screen orientation with the rest of screen emulation
> and covers window.orientation API.
>
> BUG=585185
>
> Committed: https://crrev.com/c7185a793efbeaa40e0d20d9d953bc1e2c32f5d1
> Cr-Commit-Position: refs/heads/master@{#376822}
TBR=pfeldman@chromium.org,tsepez@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=585185
Patch Set 1 #Messages
Total messages: 10 (4 generated)
|