Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1727083002: Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed)

Created:
4 years, 10 months ago by shrike
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, dgozman, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, mlamouri+watch-test-runner_chromium.org, pfeldman+blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org, jam, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews, dglazkov+blink, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (patchset #5 id:80001 of https://codereview.chromium.org/1711083002/ ) Reason for revert: Regression: WebKit Linux Leak Suspecting this cl for WebKit leak regression on Linux, from the list of cls suggested by Sheriff-o-matic ( https://chromium.googlesource.com/chromium/src/+log/b99fe46d578c03c48b58406628e27c4e0de7e0bf%5E..04f05e57fe272290b9ceddb288d919434277165e?pretty=fuller ) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak?numbuilds=50 Beginning in Build #17652 - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17652/steps/webkit_tests/logs/stdio 16:45:41.551 14179 worker/2 fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html output stderr lines: 16:45:41.551 14179 Xlib: extension "RANDR" missing on display ":9". 16:45:41.552 14179 Xlib: extension "RANDR" missing on display ":9". 16:45:41.552 14179 [31241:31241:0222/164540:1670209790:ERROR:object_proxy.cc(580)] Failed to call method: org.freedesktop.DBus.ObjectManager.GetManagedObjects: object_path= /: org.freedesktop.DBus.Error.UnknownMethod: Method "GetManagedObjects" with signature "" on interface "org.freedesktop.DBus.ObjectManager" doesn't exist 16:45:41.552 14179 16:45:41.552 14179 [31241:31241:0222/164540:1670210185:WARNING:object_manager.cc(370)] org.bluez /: Failed to get managed objects 16:45:41.552 14179 [31241:31241:0222/164540:1670212252:ERROR:object_proxy.cc(580)] Failed to call method: org.freedesktop.DBus.ObjectManager.GetManagedObjects: object_path= /: org.freedesktop.DBus.Error.UnknownMethod: Method "GetManagedObjects" with signature "" on interface "org.freedesktop.DBus.ObjectManager" doesn't exist 16:45:41.552 14179 16:45:41.552 14179 [31241:31241:0222/164540:1670212556:WARNING:object_manager.cc(370)] org.bluez /: Failed to get managed objects 16:45:41.552 14179 [31241:31349:0222/164540:1670222703:ERROR:zygote_host_impl_linux.cc(162)] Failed to adjust OOM score of renderer with pid 31366: Permission denied 16:45:41.582 14179 "/usr/bin/wdiff --help" took 0.03s 16:45:41.614 14179 "/usr/bin/wdiff --start-delete=##WDIFF_DEL## --end-delete=##WDIFF_END## --start-insert=##WDIFF_ADD## --end-insert=##WDIFF_END## /mnt/data/b/build/slave/WebKit_Linux_Leak/build/layout-test-results/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt /mnt/data/b/build/slave/WebKit_Linux_Leak/build/layout-test-results/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-actual.txt" took 0.03s 16:45:41.646 14179 "ruby --version" took 0.03s . . . Regressions: Unexpected text-only failures (1) fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html [ Failure Failure Failure Leak ] Regressions: Unexpected leaks (2) fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html [ Leak Leak Failure Failure ] fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html [ Leak Leak Leak Failure ] Original issue's description: > [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. > > This unifies screen orientation with the rest of screen emulation > and covers window.orientation API. > > BUG=585185 > > Committed: https://crrev.com/c7185a793efbeaa40e0d20d9d953bc1e2c32f5d1 > Cr-Commit-Position: refs/heads/master@{#376822} TBR=pfeldman@chromium.org,tsepez@chromium.org,dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -181 lines) Patch
M components/test_runner/mock_screen_orientation_client.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/test_runner/mock_screen_orientation_client.cc View 2 chunks +1 line, -4 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/emulation_handler.h View 1 chunk +12 lines, -14 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 4 chunks +1 line, -42 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/devtools/render_widget_screen_metrics_emulator.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html View 3 chunks +19 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 7 chunks +28 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 4 chunks +28 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp View 5 chunks +31 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.h View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp View 1 chunk +112 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebDeviceEmulationParams.h View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shrike
Created Revert of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator.
4 years, 10 months ago (2016-02-24 01:17:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727083002/1
4 years, 10 months ago (2016-02-24 01:19:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727083002/1
4 years, 10 months ago (2016-02-24 01:35:00 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/26146) linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-24 01:38:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727083002/1
4 years, 10 months ago (2016-02-24 18:05:26 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:17:08 UTC) #9
Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698