gin: Add out-of-line copy ctors for complex classes.

gin: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=aa@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/8ed6f86e3e08945205747a74de58972d57851968
Cr-Commit-Position: refs/heads/master@{#377655}

[vmpstr, 2016-02-24 00:28:44]

Please take a look.

[dcheng, 2016-02-24 01:23:49]

lgtm

(this directory needs update OWNERS, aa@ and abarth@ both don't work on chromium
anymore)

[Nico, 2016-02-24 01:30:50]

thakis@chromium.org changed reviewers:
+ jochen@chromium.org

[Nico, 2016-02-24 01:30:50]

lgtm2

jochen, can you a) owner-stamp b) update gin/OWNERS?

[jochen (gone - plz use gerrit), 2016-02-24 08:22:54]

again, shouldn't those classes now also get operator=?

[vmpstr, 2016-02-25 00:03:44]

On 2016/02/24 08:22:54, jochen wrote:
> again, shouldn't those classes now also get operator=?

That's probably true, since one would be implicitly created inline. Maybe we can
update the clang plugin to detect those cases as well? I'll file a bug.

[vmpstr, 2016-02-25 00:05:53]

On 2016/02/25 00:03:44, vmpstr wrote:
> On 2016/02/24 08:22:54, jochen wrote:
> > again, shouldn't those classes now also get operator=?
> 
> That's probably true, since one would be implicitly created inline. Maybe we
can
> update the clang plugin to detect those cases as well? I'll file a bug.

Filed crbug.com/589666.

jochen@, are you OK with this change as is, or did you want me to update it?

[jochen (gone - plz use gerrit), 2016-02-25 11:56:34]

lgtm

[vmpstr, 2016-02-25 18:53:12]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-02-25 18:57:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1727063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1727063002/1

[commit-bot: I haz the power, 2016-02-25 20:25:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-25 20:26:33]

Description was changed from

==========
gin: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=aa@chromium.org, dcheng@chromium.org, thakis@chromium.org
==========

to

==========
gin: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=aa@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/8ed6f86e3e08945205747a74de58972d57851968
Cr-Commit-Position: refs/heads/master@{#377655}
==========

[commit-bot: I haz the power, 2016-02-25 20:26:34]

Patchset 1 (id:??) landed as
https://crrev.com/8ed6f86e3e08945205747a74de58972d57851968
Cr-Commit-Position: refs/heads/master@{#377655}