base/metrics/sparse_histogram.cc - Issue 1726873002: Report histogram creation results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/sparse_histogram.cc

Issue 1726873002: Report histogram creation results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added message for why not using macro Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/sparse_histogram.cc

diff --git a/base/metrics/sparse_histogram.cc b/base/metrics/sparse_histogram.cc

index 5653456a29fb552470871f8611cb6337ec65bc50..473308cdcbe05e09d13a5a3c8f3a554783e7cfac 100644

--- a/base/metrics/sparse_histogram.cc

+++ b/base/metrics/sparse_histogram.cc

@@ -29,6 +29,9 @@ HistogramBase* SparseHistogram::FactoryGet(const std::string& name,

tentative_histogram->SetFlags(flags);

histogram =

StatisticsRecorder::RegisterOrDeleteDuplicate(tentative_histogram);

+ ReportHistogramActivity(histogram, HISTOGRAM_CREATED);

+ } else {

+ ReportHistogramActivity(histogram, HISTOGRAM_LOOKUP);

}

DCHECK_EQ(SPARSE_HISTOGRAM, histogram->GetHistogramType());

return histogram;