base/metrics/histogram_persistence.cc - Issue 1726873002: Report histogram creation results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_persistence.cc

Issue 1726873002: Report histogram creation results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added message for why not using macro Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_persistence.cc

diff --git a/base/metrics/histogram_persistence.cc b/base/metrics/histogram_persistence.cc

index f18d17528354329cd4995615d2451f6a52c59302..17ec35af6f807ee9c53b199b109fcbcb6c105845 100644

--- a/base/metrics/histogram_persistence.cc

+++ b/base/metrics/histogram_persistence.cc

@@ -187,6 +187,12 @@ void SetPersistentHistogramMemoryAllocator(

// also released, future accesses to those histograms will seg-fault.

CHECK(!g_allocator);

g_allocator = allocator;

+ size_t existing = StatisticsRecorder::GetHistogramCount();

+ if (existing != 0) {

+ DLOG(WARNING) << existing

+ << " histograms were created before persistence was enabled.";

+ }

}

PersistentMemoryAllocator* GetPersistentHistogramMemoryAllocator() {