Refactor service tests in preparation of running on sky_shell

Refactor service tests in preparation of running on sky_shell

- Split service test common helper into separate file.
- Make many tests easier to adapt to line number changes.
- Refactor test launching in preparation of running these tests against sky_shell
- Pass --testee-mode as an environment variable instead of of a command line flag because Flutter applications cannot receive command line arguments.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/7656cedf471a030a6d852d931cd453cd8851bd3b

[Cutch, 2016-02-23 18:10:24]

Description was changed from

==========
Refactor service tests

- Split service test common helper into separate file.
- Make many tests easier to adapt to line number changes.
- Refactor test launching in prepation of running these tests against sky_shell

BUG=
==========

to

==========
Refactor service tests

- Split service test common helper into separate file.
- Make many tests easier to adapt to line number changes.
- Refactor test launching in preparation of running these tests against
sky_shell
- Pass --testee-mode as an environment variable instead of of a command line
flag because Flutter applications cannot receive command line arguments.

BUG=
==========

[Cutch, 2016-02-23 18:10:25]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-23 18:11:52]

Description was changed from

==========
Refactor service tests

- Split service test common helper into separate file.
- Make many tests easier to adapt to line number changes.
- Refactor test launching in preparation of running these tests against
sky_shell
- Pass --testee-mode as an environment variable instead of of a command line
flag because Flutter applications cannot receive command line arguments.

BUG=
==========

to

==========
Refactor service tests in preparation of running on sky_shell

- Split service test common helper into separate file.
- Make many tests easier to adapt to line number changes.
- Refactor test launching in preparation of running these tests against
sky_shell
- Pass --testee-mode as an environment variable instead of of a command line
flag because Flutter applications cannot receive command line arguments.

BUG=
==========

[rmacnak, 2016-02-23 18:29:43]

lgtm w/c

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/coverage_test.dart (right):

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/coverage_test.dart:20: if (value < 0) {
// line A

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/coverage_test.dart:38:
MyClass.otherFunction(-100);
// line B

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/coverage_test.dart:136: main(args) =>
runIsolateTests(args, tests,
// line C

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/issue_25465_test.dart (right):

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/issue_25465_test.dart:16: var foo;      //
line 11
A

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/issue_25465_test.dart:17: foo = 42;     //
line 12
B

[Cutch, 2016-02-23 18:39:42]

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/coverage_test.dart (right):

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/coverage_test.dart:20: if (value < 0) {
On 2016/02/23 18:29:42, rmacnak wrote:
> // line A

Done.

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/coverage_test.dart:38:
MyClass.otherFunction(-100);
On 2016/02/23 18:29:43, rmacnak wrote:
> // line B

Done.

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/coverage_test.dart:136: main(args) =>
runIsolateTests(args, tests,
On 2016/02/23 18:29:43, rmacnak wrote:
> // line C

Done.

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/issue_25465_test.dart (right):

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/issue_25465_test.dart:16: var foo;      //
line 11
On 2016/02/23 18:29:43, rmacnak wrote:
> A

Done.

https://codereview.chromium.org/1726773002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/issue_25465_test.dart:17: foo = 42;     //
line 12
On 2016/02/23 18:29:43, rmacnak wrote:
> B

Done.

[Cutch, 2016-02-23 18:50:40]

Description was changed from

==========
Refactor service tests in preparation of running on sky_shell

- Split service test common helper into separate file.
- Make many tests easier to adapt to line number changes.
- Refactor test launching in preparation of running these tests against
sky_shell
- Pass --testee-mode as an environment variable instead of of a command line
flag because Flutter applications cannot receive command line arguments.

BUG=
==========

to

==========
Refactor service tests in preparation of running on sky_shell

- Split service test common helper into separate file.
- Make many tests easier to adapt to line number changes.
- Refactor test launching in preparation of running these tests against
sky_shell
- Pass --testee-mode as an environment variable instead of of a command line
flag because Flutter applications cannot receive command line arguments.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7656cedf471a030a6d852d931cd453cd8851bd3b
==========

[Cutch, 2016-02-23 18:50:41]

Committed patchset #2 (id:20001) manually as
7656cedf471a030a6d852d931cd453cd8851bd3b (presubmit successful).