runtime/observatory/tests/service/step_into_async_no_await_test.dart - Issue 1726773002: Refactor service tests in preparation of running on sky_shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/step_into_async_no_await_test.dart

Issue 1726773002: Refactor service tests in preparation of running on sky_shell (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/smart_next_test.dart ('k') | runtime/observatory/tests/service/step_over_await_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/step_into_async_no_await_test.dart

diff --git a/runtime/observatory/tests/service/step_into_async_no_await_test.dart b/runtime/observatory/tests/service/step_into_async_no_await_test.dart

index f9dddd564e97173c4cb66f0dc0a61705d0117cc0..fcae338af2d62079f1bb4cb31088453e3154a128 100644

--- a/runtime/observatory/tests/service/step_into_async_no_await_test.dart

+++ b/runtime/observatory/tests/service/step_into_async_no_await_test.dart

@@ -5,6 +5,9 @@

import 'test_helper.dart';

import 'dart:developer';

+import 'service_test_common.dart';

+const int LINE_A = 20;

// :async_op will not be captured in this function because it never needs to

// reschedule it.

@@ -14,12 +17,12 @@ asyncWithoutAwait() async {

testMain() {

debugger();

- asyncWithoutAwait(); // Line 17

+ asyncWithoutAwait(); // Line A.

}

var tests = [

hasStoppedAtBreakpoint,

- stoppedAtLine(17),

+ stoppedAtLine(LINE_A),

(isolate) => isolate.stepInto(),

hasStoppedAtBreakpoint,

(isolate) => isolate.getStack(), // Should not crash.