Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172673002: Base: Don't check for thread restrictions when closing a file doesn't do IO. (Closed)

Created:
6 years, 10 months ago by rvargas (doing something else)
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Base: Don't check for thread restrictions when closing a file doesn't do IO. Also, clarify the File API a little more. BUG=322664 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M base/files/file.h View 1 chunk +5 lines, -1 line 0 comments Download
M base/files/file_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rvargas (doing something else)
6 years, 10 months ago (2014-02-19 18:06:44 UTC) #1
Nico
lgtm
6 years, 10 months ago (2014-02-20 00:13:11 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 10 months ago (2014-02-20 15:03:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/172673002/1
6 years, 10 months ago (2014-02-20 15:03:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 16:24:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=267020
6 years, 10 months ago (2014-02-20 16:24:06 UTC) #6
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 10 months ago (2014-02-20 22:06:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/172673002/1
6 years, 10 months ago (2014-02-20 22:10:46 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 00:04:06 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=267415
6 years, 10 months ago (2014-02-21 00:04:07 UTC) #10
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 10 months ago (2014-02-21 15:07:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/172673002/1
6 years, 10 months ago (2014-02-21 15:08:08 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 17:25:56 UTC) #13
Message was sent while issue was closed. 
Change committed as 252585

Powered by Google App Engine
This is Rietveld 408576698