base/files/file_win.cc - Issue 172673002: Base: Don't check for thread restrictions when closing a file doesn't do IO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_win.cc

Issue 172673002: Base: Don't check for thread restrictions when closing a file doesn't do IO. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/files/file_win.cc

diff --git a/base/files/file_win.cc b/base/files/file_win.cc

index 80f46136c7acacc0ccca1a0763b363d18107097d..3581fca723077d7bc72822c937da5e3d647d7ebd 100644

--- a/base/files/file_win.cc

+++ b/base/files/file_win.cc

@@ -104,8 +104,10 @@ PlatformFile File::TakePlatformFile() {

}

void File::Close() {

- base::ThreadRestrictions::AssertIOAllowed();

- file_.Close();

+ if (file_.IsValid()) {

+ base::ThreadRestrictions::AssertIOAllowed();

+ file_.Close();

+ }

}

int64 File::Seek(Whence whence, int64 offset) {

« no previous file with comments | « base/files/file_posix.cc ('k') | no next file » | no next file with comments »