Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: content/shell/shell_layout_tests_android.h

Issue 17265005: content_shell: Create the FIFOs needed for running Android layout tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/shell_layout_tests_android.h
diff --git a/content/shell/shell_layout_tests_android.h b/content/shell/shell_layout_tests_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..33c1e800222ea3631247523ed6ae72f334967d39
--- /dev/null
+++ b/content/shell/shell_layout_tests_android.h
@@ -0,0 +1,21 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
jochen (gone - plz use gerrit) 2013/06/19 17:58:47 nit. the latest and greatest copyright header does
Peter Beverloo 2013/06/19 19:48:32 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_SHELL_SHELL_LAYOUT_TESTS_ANDROID_H_
+#define CONTENT_SHELL_SHELL_LAYOUT_TESTS_ANDROID_H_
+
+extern const char kAndroidLayoutTestPath[];
jochen (gone - plz use gerrit) 2013/06/19 17:58:47 content_shell is in the content namespace
Peter Beverloo 2013/06/19 19:48:32 ShellBrowserMain() is not. I've changed it for th
+extern const char kAndroidLayoutTestBase[];
bulach 2013/06/19 17:57:42 as above, replace those with a nice looking functi
Peter Beverloo 2013/06/19 19:48:32 Done.
+
+// Android will need three FIFOs to communicate with the Blink test runner,
+// one for each of [stdout, stderr, stdin]. Create them and verify that all
+// streams have been redirected to their FIFOs using a CHECK().
+void EnsureCreateAndroidFIFOs();
+
+// Android uses a nested message loop in order to be able to utilize a
+// base::RunLoop for executing a single layout test. Initialize it and verify
+// this using a CHECK().
+void EnsureCreateAndroidNestedMessagePump();
bulach 2013/06/19 17:57:42 also, combine both functions here.
Peter Beverloo 2013/06/19 19:48:32 Done.
+
+#endif // CONTENT_SHELL_SHELL_LAYOUT_TESTS_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698