content/shell/shell_layout_tests_android.h - Issue 17265005: content_shell: Create the FIFOs needed for running Android layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/shell_layout_tests_android.h

Issue 17265005: content_shell: Create the FIFOs needed for running Android layout tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	jochen (gone - plz use gerrit) 2013/06/19 17:58:47 nit. the latest and greatest copyright header does nit. the latest and greatest copyright header doesn't have a (c) in it Peter Beverloo 2013/06/19 19:48:32 Done. Show quoted text On 2013/06/19 17:58:47, jochen wrote: > nit. the latest and greatest copyright header doesn't have a (c) in it Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_SHELL_SHELL_LAYOUT_TESTS_ANDROID_H_

	6 #define CONTENT_SHELL_SHELL_LAYOUT_TESTS_ANDROID_H_

	7

	8 extern const char kAndroidLayoutTestPath[];
	jochen (gone - plz use gerrit) 2013/06/19 17:58:47 content_shell is in the content namespace content_shell is in the content namespace Peter Beverloo 2013/06/19 19:48:32 ShellBrowserMain() is not. I've changed it for th ShellBrowserMain() is not. I've changed it for these files.
	9 extern const char kAndroidLayoutTestBase[];
	bulach 2013/06/19 17:57:42 as above, replace those with a nice looking functi as above, replace those with a nice looking function. :) Peter Beverloo 2013/06/19 19:48:32 Done. Show quoted text On 2013/06/19 17:57:42, bulach wrote: > as above, replace those with a nice looking function. :) Done.
	10

	11 // Android will need three FIFOs to communicate with the Blink test runner,

	12 // one for each of [stdout, stderr, stdin]. Create them and verify that all

	13 // streams have been redirected to their FIFOs using a CHECK().

	14 void EnsureCreateAndroidFIFOs();

	15

	16 // Android uses a nested message loop in order to be able to utilize a

	17 // base::RunLoop for executing a single layout test. Initialize it and verify

	18 // this using a CHECK().

	19 void EnsureCreateAndroidNestedMessagePump();
	bulach 2013/06/19 17:57:42 also, combine both functions here. also, combine both functions here. Peter Beverloo 2013/06/19 19:48:32 Done. Show quoted text On 2013/06/19 17:57:42, bulach wrote: > also, combine both functions here. Done.
	20

	21 #endif // CONTENT_SHELL_SHELL_LAYOUT_TESTS_ANDROID_H_

OLD	NEW

« content/shell/shell_browser_main.cc ('K') | « content/shell/shell_browser_main.cc ('k') | content/shell/shell_layout_tests_android.cc » ('j') | no next file with comments »