Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1726403007: Remove Vk files with spurious CRLFs (Closed)

Created:
4 years, 10 months ago by jvanverth1
Modified:
4 years, 10 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1027 lines) Patch
M gyp/gpu.gypi View 1 3 chunks +6 lines, -6 lines 0 comments Download
D src/gpu/vk/GrVkProgram.h View 1 chunk +0 lines, -161 lines 0 comments Download
D src/gpu/vk/GrVkProgram.cpp View 1 chunk +0 lines, -367 lines 0 comments Download
D src/gpu/vk/GrVkProgramBuilder.cpp View 1 chunk +0 lines, -323 lines 0 comments Download
D src/gpu/vk/GrVkProgramDataManager.h View 1 chunk +0 lines, -70 lines 0 comments Download
D src/gpu/vk/GrVkSampler.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D src/gpu/vk/GrVkVaryingHandler.cpp View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jvanverth1
4 years, 10 months ago (2016-02-26 16:38:07 UTC) #3
egdaniel
lgtm but you might need to comment them out in gpu.gypi for whatever reason the ...
4 years, 10 months ago (2016-02-26 16:39:26 UTC) #4
jvanverth1
On 2016/02/26 16:39:26, egdaniel wrote: > lgtm but you might need to comment them out ...
4 years, 10 months ago (2016-02-26 16:50:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726403007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726403007/20001
4 years, 10 months ago (2016-02-26 16:51:10 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 17:05:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e02918dc34701a258c5b3b56b294e48641983b91

Powered by Google App Engine
This is Rietveld 408576698