chrome/browser/safe_browsing/ui_manager.h - Issue 1726403006: Switch Safe Browsing's metadata from string to struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ui_manager.h

Issue 1726403006: Switch Safe Browsing's metadata from string to struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ParseJson in test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/ui_manager.h

diff --git a/chrome/browser/safe_browsing/ui_manager.h b/chrome/browser/safe_browsing/ui_manager.h

index 7932508b042fe2bba40f0e4b48fda6316a904235..20a6869b684c1665014363c0c802c525783f3c85 100644

--- a/chrome/browser/safe_browsing/ui_manager.h

+++ b/chrome/browser/safe_browsing/ui_manager.h

@@ -77,7 +77,7 @@ class SafeBrowsingUIManager

bool is_subresource;

bool is_subframe;

SBThreatType threat_type;

- std::string threat_metadata;

+ ThreatMetadata threat_metadata;

UrlCheckCallback callback; // This is called back on |callback_thread|.

scoped_refptr<base::SingleThreadTaskRunner> callback_thread;

int render_process_host_id;

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_test.cc ('k') | chrome/browser/safe_browsing/ui_manager.cc » ('j') | no next file with comments »