chrome/browser/safe_browsing/safe_browsing_test.cc - Issue 1726403006: Switch Safe Browsing's metadata from string to struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_test.cc

Issue 1726403006: Switch Safe Browsing's metadata from string to struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ParseJson in test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc ('k') | chrome/browser/safe_browsing/ui_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_test.cc b/chrome/browser/safe_browsing/safe_browsing_test.cc

index 50b81e85b91aae3ee295147c32886d2f5b18de26..71542dbfc8312e53400f93dbcb82efad36b253e0 100644

--- a/chrome/browser/safe_browsing/safe_browsing_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_test.cc

@@ -355,7 +355,7 @@ class SafeBrowsingServerTestHelper

// Callbacks for SafeBrowsingDatabaseManager::Client.

void OnCheckBrowseUrlResult(const GURL& url,

SBThreatType threat_type,

- const std::string& metadata) override {

+ const ThreatMetadata& metadata) override {

EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

EXPECT_TRUE(safe_browsing_test_->is_checked_url_in_db());

safe_browsing_test_->set_is_checked_url_safe(

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc ('k') | chrome/browser/safe_browsing/ui_manager.h » ('j') | no next file with comments »