chrome/browser/safe_browsing/protocol_parser.cc - Issue 1726403006: Switch Safe Browsing's metadata from string to struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 1726403006: Switch Safe Browsing's metadata from string to struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ParseJson in test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.h ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/protocol_parser.cc

diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc

index 398426c451817dd66e22fa9e43ccacd158745551..60e330408c7abaa102db08bd0e422e97da123d1b 100644

--- a/chrome/browser/safe_browsing/protocol_parser.cc

+++ b/chrome/browser/safe_browsing/protocol_parser.cc

@@ -155,8 +155,9 @@ bool ParseGetHashMetadata(

return false;

if (full_hashes) {

- (*full_hashes)[full_hashes->size() - hash_count + i].metadata.assign(

- reinterpret_cast<const char*>(meta_data), meta_data_len);

+ (*full_hashes)[full_hashes->size() - hash_count + i]

+ .metadata.raw_metadata.assign(

+ reinterpret_cast<const char*>(meta_data), meta_data_len);

}

return true;

« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.h ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | no next file with comments »