chrome/browser/safe_browsing/local_database_manager.h - Issue 1726403006: Switch Safe Browsing's metadata from string to struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/local_database_manager.h

Issue 1726403006: Switch Safe Browsing's metadata from string to struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ParseJson in test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('k') | chrome/browser/safe_browsing/protocol_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/local_database_manager.h

diff --git a/chrome/browser/safe_browsing/local_database_manager.h b/chrome/browser/safe_browsing/local_database_manager.h

index 4c9427aa4c53349c0b78d8fd9c63ff9029304ec4..ad8bcd842bdabe6e9699e6c8500343209b5e7919 100644

--- a/chrome/browser/safe_browsing/local_database_manager.h

+++ b/chrome/browser/safe_browsing/local_database_manager.h

@@ -72,7 +72,7 @@ class LocalSafeBrowsingDatabaseManager

// initialized to be empty strings.

std::vector<GURL> urls;

std::vector<SBThreatType> url_results;

- std::vector<std::string> url_metadata;

+ std::vector<ThreatMetadata> url_metadata;

std::vector<std::string> url_hit_hash;

std::vector<SBFullHash> full_hashes;

std::vector<SBThreatType> full_hash_results;

« no previous file with comments | « chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('k') | chrome/browser/safe_browsing/protocol_parser.cc » ('j') | no next file with comments »