xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp

diff --git a/xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp b/xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp

index 1bb5a295a05befdc377547d80a8b7a9dd7e683fe..97c6c2a091118252fe180a65aefafd42115bcf5c 100644

--- a/xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp

+++ b/xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp

@@ -67,9 +67,8 @@ CBC_QRCoderFormatInformation::DecodeFormatInformation(

int32_t maskedFormatInfo) {

CBC_QRCoderFormatInformation* formatInfo =

DoDecodeFormatInformation(maskedFormatInfo);

- if (formatInfo != NULL) {

+ if (formatInfo)

return formatInfo;

- }

return DoDecodeFormatInformation(maskedFormatInfo ^ FORMAT_INFO_MASK_QR);

}

CBC_QRCoderFormatInformation*