xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp - Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp

Issue 1726373002: Remove foo != NULL checks in xfa/src/fxbarcode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp

diff --git a/xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp b/xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp

index fe05069d4f4dfbb66ded1347ff7c299194f274bc..1cb08cd9b8c7e273cdbaf659a69604e0dc7c6f0d 100644

--- a/xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp

+++ b/xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp

@@ -81,10 +81,7 @@ int32_t CBC_OnedEAN13Reader::DecodeMiddle(CBC_CommonBitArray* row,

FindGuardPattern(row, rowOffset, TRUE, &result, e);

BC_EXCEPTION_CHECK_ReturnValue(e, 0);

rowOffset = (*middleRange)[1];

- if (middleRange != NULL) {

- delete middleRange;

- middleRange = NULL;

- }

+ delete middleRange;

for (int32_t Y = 0; Y < 6 && rowOffset < end; Y++) {

int32_t bestMatch =

DecodeDigit(row, &counters, rowOffset,