Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context.h

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_permission_context.h
diff --git a/chrome/browser/push_messaging/push_messaging_permission_context.h b/chrome/browser/push_messaging/push_messaging_permission_context.h
index f137751ce424eb1f1efb227c848c25f8f1f99d18..dfd2911970c3410a8113c5cf54e6798fdab74a35 100644
--- a/chrome/browser/push_messaging/push_messaging_permission_context.h
+++ b/chrome/browser/push_messaging/push_messaging_permission_context.h
@@ -21,15 +21,15 @@ class PushMessagingPermissionContext : public PermissionContextBase {
// PermissionContextBase:
ContentSetting GetPermissionStatus(
- const GURL& requesting_origin,
- const GURL& embedding_origin) const override;
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) const override;
protected:
// PermissionContextBase:
void DecidePermission(content::WebContents* web_contents,
const PermissionRequestID& id,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin,
const BrowserPermissionCallback& callback) override;
bool IsRestrictedToSecureOrigins() const override;
@@ -43,8 +43,8 @@ class PushMessagingPermissionContext : public PermissionContextBase {
// Used to decide the permission for push, once the permission for
// Notification has been granted/denied.
void DecidePushPermission(const PermissionRequestID& id,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin,
const BrowserPermissionCallback& callback,
ContentSetting notifications_content_setting);
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.cc ('k') | chrome/browser/push_messaging/push_messaging_permission_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698