Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 4a3f649c8d67a512548806aa8736de0876f2a05c..6973c39a47fb6e044265e5756b9d932ccf373713 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -17,6 +17,7 @@
#include "content/public/browser/permission_type.h"
#include "content/public/common/origin_util.h"
#include "url/gurl.h"
+#include "url/origin.h"
// UMA keys need to be statically initialized so plain function would not
// work. Use a Macro instead.
@@ -229,8 +230,8 @@ void RecordPermissionRequest(PermissionType permission,
if (!manager)
return;
content::mojom::PermissionStatus embedding_permission_status =
- manager->GetPermissionStatus(permission, embedding_origin,
- embedding_origin);
+ manager->GetPermissionStatus(permission, url::Origin(embedding_origin),
+ url::Origin(embedding_origin));
base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
"Permissions.Requested.CrossOrigin_" +

Powered by Google App Engine
This is Rietveld 408576698