Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2482)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
index febbb01a492977aaaecb5ac7fa4bc860fb981047..53d7b487d1a9bb6223a490db8579e8200723cf99 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
@@ -18,6 +18,7 @@
#include "content/public/browser/user_metrics.h"
#include "extensions/browser/guest_view/web_view/web_view_constants.h"
#include "extensions/browser/guest_view/web_view/web_view_guest.h"
+#include "url/origin.h"
namespace extensions {
@@ -226,12 +227,11 @@ void ChromeWebViewPermissionHelperDelegate::OnGeolocationPermissionResponse(
Profile* profile = Profile::FromBrowserContext(
web_view_guest()->browser_context());
- GeolocationPermissionContextFactory::GetForProfile(profile)->
- RequestPermission(
- web_contents,
- request_id,
- web_view_guest()->embedder_web_contents()
- ->GetLastCommittedURL().GetOrigin(),
+ GeolocationPermissionContextFactory::GetForProfile(profile)
+ ->RequestPermission(
+ web_contents, request_id,
+ url::Origin(
+ web_view_guest()->embedder_web_contents()->GetLastCommittedURL()),
callback);
}
« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_unittest.cc ('k') | chrome/browser/media/media_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698