chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 1726323002: Have Permission{Manager,Service} use Origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_extensions.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

index 122499b0b9ed440e2d76ec6a6019f90b6bc136b2..61540911477a1bd787cd96f2023ea16a150d4b28 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

@@ -46,6 +46,7 @@

#include "content/public/test/test_utils.h"

#include "content/public/test/web_contents_tester.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "url/origin.h"

#if BUILDFLAG(ANDROID_JAVA_UI)

#include "chrome/browser/android/mock_location_settings.h"

@@ -195,7 +196,7 @@ void GeolocationPermissionContextTests::RequestGeolocationPermission(

const PermissionRequestID& id,

const GURL& requesting_frame) {

geolocation_permission_context_->RequestPermission(

- web_contents, id, requesting_frame,

+ web_contents, id, url::Origin(requesting_frame),

base::Bind(&GeolocationPermissionContextTests::PermissionResponse,

base::Unretained(this), id));

content::RunAllBlockingPoolTasksUntilIdle();