Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3410)

Unified Diff: chromecast/browser/cast_permission_manager.h

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_permission_manager.h
diff --git a/chromecast/browser/cast_permission_manager.h b/chromecast/browser/cast_permission_manager.h
index 432fef26505598fb3e681004febf4cbfa68223f1..3c3b4595ea0317e50dae6ac4e2a22de03915f8e6 100644
--- a/chromecast/browser/cast_permission_manager.h
+++ b/chromecast/browser/cast_permission_manager.h
@@ -21,29 +21,29 @@ class CastPermissionManager : public content::PermissionManager {
int RequestPermission(
content::PermissionType permission,
content::RenderFrameHost* render_frame_host,
- const GURL& requesting_origin,
+ const url::Origin& requesting_origin,
const base::Callback<void(content::PermissionStatus)>& callback) override;
int RequestPermissions(
const std::vector<content::PermissionType>& permission,
content::RenderFrameHost* render_frame_host,
- const GURL& requesting_origin,
- const base::Callback<void(
- const std::vector<content::PermissionStatus>&)>& callback) override;
+ const url::Origin& requesting_origin,
+ const base::Callback<void(const std::vector<content::PermissionStatus>&)>&
+ callback) override;
void CancelPermissionRequest(int request_id) override;
void ResetPermission(content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) override;
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) override;
content::PermissionStatus GetPermissionStatus(
content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) override;
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) override;
void RegisterPermissionUsage(content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin) override;
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin) override;
int SubscribePermissionStatusChange(
content::PermissionType permission,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin,
const base::Callback<void(content::PermissionStatus)>& callback) override;
void UnsubscribePermissionStatusChange(int subscription_id) override;

Powered by Google App Engine
This is Rietveld 408576698