Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/browser/storage/durable_storage_permission_context.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage/durable_storage_permission_context.cc
diff --git a/chrome/browser/storage/durable_storage_permission_context.cc b/chrome/browser/storage/durable_storage_permission_context.cc
index 1d82b1fa8cc00b618ec151ec108934c8815a10b1..3bc80208bdc0d308eb695d4beb4a0d341f259750 100644
--- a/chrome/browser/storage/durable_storage_permission_context.cc
+++ b/chrome/browser/storage/durable_storage_permission_context.cc
@@ -32,8 +32,8 @@ DurableStoragePermissionContext::DurableStoragePermissionContext(
void DurableStoragePermissionContext::DecidePermission(
content::WebContents* web_contents,
const PermissionRequestID& id,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin,
const BrowserPermissionCallback& callback) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
@@ -43,7 +43,7 @@ void DurableStoragePermissionContext::DecidePermission(
if (model) {
std::vector<bookmarks::BookmarkModel::URLAndTitle> bookmarks;
model->GetBookmarks(&bookmarks);
- if (IsOriginBookmarked(bookmarks, requesting_origin)) {
+ if (IsOriginBookmarked(bookmarks, GURL(requesting_origin.Serialize()))) {
NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
true /* persist */, CONTENT_SETTING_ALLOW);
return;
@@ -55,16 +55,18 @@ void DurableStoragePermissionContext::DecidePermission(
}
void DurableStoragePermissionContext::UpdateContentSetting(
- const GURL& requesting_origin,
- const GURL& embedding_origin_ignored,
+ const url::Origin& requesting_origin,
+ const url::Origin& embedding_origin_ignored,
ContentSetting content_setting) {
- DCHECK_EQ(requesting_origin, requesting_origin.GetOrigin());
- DCHECK_EQ(embedding_origin_ignored, embedding_origin_ignored.GetOrigin());
+ const GURL requesting_url(requesting_origin.Serialize());
+ const GURL embedding_url(embedding_origin_ignored.Serialize());
+ DCHECK_EQ(requesting_origin, url::Origin(requesting_url));
+ DCHECK_EQ(embedding_origin_ignored, url::Origin(embedding_url));
DCHECK(content_setting == CONTENT_SETTING_ALLOW ||
content_setting == CONTENT_SETTING_BLOCK);
HostContentSettingsMapFactory::GetForProfile(profile())->SetContentSetting(
- ContentSettingsPattern::FromURLNoWildcard(requesting_origin),
+ ContentSettingsPattern::FromURLNoWildcard(requesting_url),
ContentSettingsPattern::Wildcard(), CONTENT_SETTINGS_TYPE_DURABLE_STORAGE,
std::string(), content_setting);
}

Powered by Google App Engine
This is Rietveld 408576698