Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/permissions/permission_context_base.cc ('K') | « chrome/browser/permissions/permission_manager_unittest.cc ('k') | chrome/browser/push_messaging/push_messaging_permission_context.h » ('j') | url/origin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 77b5f0930f84ce62792b4df51997cdafac7ee3e6..fee2dcada1a93aff6588cdd1f3b87ab1688bb0d2 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -17,6 +17,7 @@
#include "content/public/browser/permission_type.h"
#include "content/public/common/origin_util.h"
#include "url/gurl.h"
+#include "url/origin.h"
// UMA keys need to be statically initialized so plain function would not
// work. Use a Macro instead.
@@ -230,8 +231,8 @@ void RecordPermissionRequest(PermissionType permission,
if (!manager)
return;
content::PermissionStatus embedding_permission_status =
- manager->GetPermissionStatus(permission, embedding_origin,
- embedding_origin);
+ manager->GetPermissionStatus(permission, url::Origin(embedding_origin),
+ url::Origin(embedding_origin));
base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
"Permissions.Requested.CrossOrigin_" +
« chrome/browser/permissions/permission_context_base.cc ('K') | « chrome/browser/permissions/permission_manager_unittest.cc ('k') | chrome/browser/push_messaging/push_messaging_permission_context.h » ('j') | url/origin.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698