Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify and test Origin.empty_. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
11 #include "chrome/browser/browser_process.h" 11 #include "chrome/browser/browser_process.h"
12 #include "chrome/browser/permissions/permission_manager.h" 12 #include "chrome/browser/permissions/permission_manager.h"
13 #include "chrome/browser/permissions/permission_util.h" 13 #include "chrome/browser/permissions/permission_util.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "components/rappor/rappor_service.h" 15 #include "components/rappor/rappor_service.h"
16 #include "components/rappor/rappor_utils.h" 16 #include "components/rappor/rappor_utils.h"
17 #include "content/public/browser/permission_type.h" 17 #include "content/public/browser/permission_type.h"
18 #include "content/public/common/origin_util.h" 18 #include "content/public/common/origin_util.h"
19 #include "url/gurl.h" 19 #include "url/gurl.h"
20 #include "url/origin.h"
20 21
21 // UMA keys need to be statically initialized so plain function would not 22 // UMA keys need to be statically initialized so plain function would not
22 // work. Use a Macro instead. 23 // work. Use a Macro instead.
23 #define PERMISSION_ACTION_UMA(secure_origin, permission, permission_secure, \ 24 #define PERMISSION_ACTION_UMA(secure_origin, permission, permission_secure, \
24 permission_insecure, action) \ 25 permission_insecure, action) \
25 UMA_HISTOGRAM_ENUMERATION(permission, action, PERMISSION_ACTION_NUM); \ 26 UMA_HISTOGRAM_ENUMERATION(permission, action, PERMISSION_ACTION_NUM); \
26 if (secure_origin) { \ 27 if (secure_origin) { \
27 UMA_HISTOGRAM_ENUMERATION(permission_secure, action, \ 28 UMA_HISTOGRAM_ENUMERATION(permission_secure, action, \
28 PERMISSION_ACTION_NUM); \ 29 PERMISSION_ACTION_NUM); \
29 } else { \ 30 } else { \
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 // In order to gauge the compatibility risk of implementing an improved 224 // In order to gauge the compatibility risk of implementing an improved
224 // iframe permissions security model, we would like to know the ratio of 225 // iframe permissions security model, we would like to know the ratio of
225 // same-origin to cross-origin permission requests. Our estimate of this 226 // same-origin to cross-origin permission requests. Our estimate of this
226 // ratio could be somewhat biased by repeated requests coming from a 227 // ratio could be somewhat biased by repeated requests coming from a
227 // single frame, but we expect this to be insignificant. 228 // single frame, but we expect this to be insignificant.
228 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) { 229 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) {
229 content::PermissionManager* manager = profile->GetPermissionManager(); 230 content::PermissionManager* manager = profile->GetPermissionManager();
230 if (!manager) 231 if (!manager)
231 return; 232 return;
232 content::PermissionStatus embedding_permission_status = 233 content::PermissionStatus embedding_permission_status =
233 manager->GetPermissionStatus(permission, embedding_origin, 234 manager->GetPermissionStatus(permission, url::Origin(embedding_origin),
234 embedding_origin); 235 url::Origin(embedding_origin));
235 236
236 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet( 237 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
237 "Permissions.Requested.CrossOrigin_" + 238 "Permissions.Requested.CrossOrigin_" +
238 PermissionUtil::GetPermissionString(permission), 239 PermissionUtil::GetPermissionString(permission),
239 1, static_cast<int>(content::PermissionStatus::LAST), 240 1, static_cast<int>(content::PermissionStatus::LAST),
240 static_cast<int>(content::PermissionStatus::LAST) + 1, 241 static_cast<int>(content::PermissionStatus::LAST) + 1,
241 base::HistogramBase::kUmaTargetedHistogramFlag); 242 base::HistogramBase::kUmaTargetedHistogramFlag);
242 histogram->Add(static_cast<int>(embedding_permission_status)); 243 histogram->Add(static_cast<int>(embedding_permission_status));
243 } else { 244 } else {
244 UMA_HISTOGRAM_ENUMERATION( 245 UMA_HISTOGRAM_ENUMERATION(
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 const GURL& revoked_origin) { 285 const GURL& revoked_origin) {
285 // TODO(tsergeant): Expand metrics definitions for revocation to include all 286 // TODO(tsergeant): Expand metrics definitions for revocation to include all
286 // permissions. 287 // permissions.
287 if (permission == PermissionType::NOTIFICATIONS || 288 if (permission == PermissionType::NOTIFICATIONS ||
288 permission == PermissionType::GEOLOCATION || 289 permission == PermissionType::GEOLOCATION ||
289 permission == PermissionType::AUDIO_CAPTURE || 290 permission == PermissionType::AUDIO_CAPTURE ||
290 permission == PermissionType::VIDEO_CAPTURE) { 291 permission == PermissionType::VIDEO_CAPTURE) {
291 RecordPermissionAction(permission, REVOKED, revoked_origin); 292 RecordPermissionAction(permission, REVOKED, revoked_origin);
292 } 293 }
293 } 294 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698